Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
This pull request introduces the
getAmountOutexternal view function to theTestAMMContract.solcontract. The function allows off-chain or frontend interfaces to estimate swap outcomes without executing transactions, improving user experience and enabling accurate slippage calculations.✨ Features Added
getAmountOutexternal view functionNatSpec documentation
@custom:previewand@custom:formulatags for developer clarity.🧠 Rationale
This addition enhances front-end and analytical tooling integration by enabling:
🧪 Files Modified
src/onchain/TestAMMContract.sol✅ Commit History
feat: Add getAmountOut External View Function Natspec Comments📅 Date
October 7, 2025
Reviewer Note:
Ensure consistency between
getAmountOutlogic and the actual swap execution function to prevent any discrepancies in user-facing calculations.